Format SQL in watcher #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added summary of the queries (total, duplicated and total duration): (Assets need to be rebuild after merging) |
|
It's a little unclear to me what the "format_sql" configuration option does. I think it will also be unclear to end users. |
|
So how would you call it? Or would you do it as default? |
|
It's replacing the |
|
Why make it a configuration option at all? Why would someone want to disable it? |
|
Not sure, because it wasn't done before I thought maybe that was on purpose. |
|
I've removed the option, just always do it now. |
|
Fixed+added a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This formats the SQL in PHP (instead of Javascript) so that they can be shown in the preview window (imho that makes it a lot more clear when looking at them, but might be preference, hence the config options).
It stores the familyHash to be able to check for duplicates (which isn't implemented anywhere yet, but would perhaps be useful).
The view of the Javascript should be the same, with/without pre-formatted SQL.